Skip to content

Conversation

@SoluMilken
Copy link
Collaborator

@SoluMilken SoluMilken commented Aug 18, 2025

Purpose

  1. Add descriptive step names.
  2. Cancel in-progress lint jobs and prioritize the latest commit.
  3. Run linting on all pull requests.

@SoluMilken SoluMilken self-assigned this Aug 18, 2025
@SoluMilken SoluMilken marked this pull request as ready for review August 18, 2025 13:57
@SoluMilken SoluMilken requested a review from john0312 August 18, 2025 13:57
@SoluMilken SoluMilken force-pushed the Yien/fix-github-workflow branch from 7909168 to 1c9630e Compare August 18, 2025 16:51
branches:
- main

# Only one lint job runs per branch. New commits cancel old lint jobs.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this per branch or per PR? It looks like it's per reference which is basically tied to the pull request?

Copy link
Collaborator Author

@SoluMilken SoluMilken Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow + branch or pr

For pushes to a branch:
It will be in the format refs/heads/<branch_name>, for example, refs/heads/main or refs/heads/feature-branch.
For pushes of a tag:
It will be in the format refs/tags/<tag_name>, for example, refs/tags/v1.0.0.
For pull requests:
It will be the pull request merge branch, typically in the format refs/pull/<pr_number>/merge. This represents the state of the code after the pull request has been merged into the target branch.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to update the comments so we're clear on this.

@SoluMilken SoluMilken force-pushed the Yien/fix-github-workflow branch from 1c9630e to 4b140b5 Compare August 21, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants