Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some translations added/corrected #174

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

Conversation

bumaas
Copy link
Contributor

@bumaas bumaas commented Mar 26, 2020

No description provided.

Radek Zajic and others added 6 commits March 8, 2020 08:34
@bumaas
Copy link
Contributor Author

bumaas commented Jul 30, 2020

Hi John,

I would be happy if you accept this PR

BR Burkhard

@@ -32,17 +32,17 @@ integral,SIN,,°min,
hcmode,UCH,0=auto;1=off;2=heat;2=water,,Boiler Modus
hcmode2,UCH,0=off;3=heat;4=water,,Boiler Modus
mcmode,UCH,0=disabled;1=on;2=off;3=auto;4=eco;5=low,,Mischer Modus
mctype,UCH,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,Mischer Typ
mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,Mischer Typ
mctype,UCH,0=inaktiv;1=Heizen;2=Festwert;3=WW;4=Rückl.anh.;5=Pool,,Mischer Typ
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookup value assignments in templates are intentionally kept identical in all languages in order to be able to switch the language without having to adjust several clients. you'd rather do a translation of these values in your own client/frontend.

@@ -1,7 +1,7 @@
# type (r[1-9];w;u),circuit,name,[comment],[QQ],ZZ,PBSB,[ID],field1,part (m/s),datatypes/templates,divider/values,unit,comment,,,
#,BAI00,ecoCompact (euro),0010015600 296,,,,,,,,,,,,,
*r,,,,,,"B509","0D",,,,,,,,,
*w,#NOT_YET_CONFIRMED,,,,,"B509","0E",,,,,,,,,
*w,,,,,,"B509","0E",,,,,,,,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you able to confirm all write values?

@@ -64,7 +64,7 @@ r,,HcStorageTempBottom,"Temp.fühler Hz, unten",,,,A000,,,tempv,,,"Temp.fühler
# ##### Warmwasserkreis #####,,,,,,,,,,,,,
*r,,,,,,B524,02000100,,,IGN:4,,,
*w,,,,,,B524,02010100,,,,,,
r;w,,HwcOpMode,HwcOpMode,,,,0300,,,opmode,,,operation mode of Hwc
r;w,,HwcOpMode,Betriebsart Warmwasserkreis,,,,0300,,,opmode,,,operation mode of the domestic hot water circuit
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have the field comment in en but the message comment in de?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have overlooked that. It should be "Operating mode of the hot water circuit".

@john30 john30 marked this pull request as draft May 8, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants