Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some translations added/corrected #174

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

bumaas
Copy link
Contributor

@bumaas bumaas commented Mar 26, 2020

No description provided.

Radek Zajic and others added 6 commits March 8, 2020 08:34
@bumaas
Copy link
Contributor Author

bumaas commented Jul 30, 2020

Hi John,

I would be happy if you accept this PR

BR Burkhard

@@ -32,17 +32,17 @@ integral,SIN,,°min,
hcmode,UCH,0=auto;1=off;2=heat;2=water,,Boiler Modus
hcmode2,UCH,0=off;3=heat;4=water,,Boiler Modus
mcmode,UCH,0=disabled;1=on;2=off;3=auto;4=eco;5=low,,Mischer Modus
mctype,UCH,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,Mischer Typ
mctype7,BI0:7,0=inactive;1=mixer;2=fixed;3=hwc;4=returnincr;5=pool,,Mischer Typ
mctype,UCH,0=inaktiv;1=Heizen;2=Festwert;3=WW;4=Rückl.anh.;5=Pool,,Mischer Typ
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookup value assignments in templates are intentionally kept identical in all languages in order to be able to switch the language without having to adjust several clients. you'd rather do a translation of these values in your own client/frontend.

@@ -1,7 +1,7 @@
# type (r[1-9];w;u),circuit,name,[comment],[QQ],ZZ,PBSB,[ID],field1,part (m/s),datatypes/templates,divider/values,unit,comment,,,
#,BAI00,ecoCompact (euro),0010015600 296,,,,,,,,,,,,,
*r,,,,,,"B509","0D",,,,,,,,,
*w,#NOT_YET_CONFIRMED,,,,,"B509","0E",,,,,,,,,
*w,,,,,,"B509","0E",,,,,,,,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you able to confirm all write values?

@@ -64,7 +64,7 @@ r,,HcStorageTempBottom,"Temp.fühler Hz, unten",,,,A000,,,tempv,,,"Temp.fühler
# ##### Warmwasserkreis #####,,,,,,,,,,,,,
*r,,,,,,B524,02000100,,,IGN:4,,,
*w,,,,,,B524,02010100,,,,,,
r;w,,HwcOpMode,HwcOpMode,,,,0300,,,opmode,,,operation mode of Hwc
r;w,,HwcOpMode,Betriebsart Warmwasserkreis,,,,0300,,,opmode,,,operation mode of the domestic hot water circuit
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have the field comment in en but the message comment in de?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have overlooked that. It should be "Operating mode of the hot water circuit".

@john30 john30 marked this pull request as draft May 8, 2022 15:36
Copy link
Owner

@john30 john30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another try to get this done

# Heatpump statistics
*r,,,,,,"B51A","05FF32",,,IGN:3,,,,
r,,EnergyHc,,,,,00,,,energy,,,,,,,,,,,,,,,
r,,EnergyHc,Energieertrag Tag Heizen,,,,00,,,energy,10,,,,,,,,,,,,,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure about the extra divisor?

*r,,,,,,"B511",,,,,,,
r,,State,,,,,07,energy,,UCH,,,,,,energy,,kWh,,onoff,,UCH,0=off;1=on,,,state,,UCH,0x01=ready;0x0b=error;0x09=heating;0x11=cooling;0x81=heating_water,,
r,,State,,,,,07,field1,,UCH,,,,,,energy,10,kWh,Täglicher Energieertrag,onoff,,UCH,0=off;1=on,,,state,,UCH,0x00=ready;0x01=ready;0x0b=error;0x08=heating;0x09=heating;0x11=cooling;0x80=heating_water;0x81=heating_water,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure about the extra divisor?

#r,,F22,F22,,,,22,f22,,D1B,,,,,,,,,,,,,,,,,,,,,
r,,CurrentYieldPower,Kälteleistung,,,,23,yieldpower,,D1B,10,kW,,,,,,,,,,,,,,,,,,,
r,,CurrentConsumedPower,elektrische Leistungsaufnahme,,,,24,consumedpower,,D1B,10,kW,,,,,,,,,,,,,,,,,,,
r,,CurrentCompressorUtil,Modulation Kompressor,,,,25,compressorutil,,D2C,,%,,,,,,,,,,,,,,,,,,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure about D2C? in live monitor it seems to be D1B instead

r,,EnergyIntegral,Energie Integral,,,,21,energyintegral,,SLG,,°min,,,,,,,,,,,,,,,,,
#r,,F22,F22,,,,22,f22,,D1B,,,,,,,,,,,,,,,,,,,,,
r,,CurrentYieldPower,Kälteleistung,,,,23,yieldpower,,D1B,10,kW,,,,,,,,,,,,,,,,,,,
r,,CurrentConsumedPower,elektrische Leistungsaufnahme,,,,24,consumedpower,,D1B,10,kW,,,,,,,,,,,,,,,,,,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure about D1B/10? in live monitor it seems to be UIN/10 instead

r,,F20,F20,,,,20,f20,,D2B,,,,,,,,,,,,,,,,,,,,,
r,,EnergyIntegral,Energie Integral,,,,21,energyintegral,,SLG,,°min,,,,,,,,,,,,,,,,,
#r,,F22,F22,,,,22,f22,,D1B,,,,,,,,,,,,,,,,,,,,,
r,,CurrentYieldPower,Kälteleistung,,,,23,yieldpower,,D1B,10,kW,,,,,,,,,,,,,,,,,,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure about D1B/10? in live monitor it seems to be UIN/10 instead

r,,PrioritySwitchingValve,Vorrangumschaltventil WW,,,,0203ffff,,,UIN,0=Heizen;1=Warmwasser,,T.1.02 Vorrangumschaltventil WW
r,,CylinderTemp,Speichertemperatur,,,,2c03ffff,,,SIN,10,°C,T.1.44 Speichertemperatur
r,,LockoutContactS20,Sperrkontakt S20,,,,2e03ffff,,,UIN,0=geschlossen;1=offen,,T.1.46 Sperrkontakt S20
r,,OutdoorTemp,Außentemperatur,,,,4503ffff,,,SIN,10,°C,T.1.69 Außentemperatur
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check any of the SIN/10 °C values to be really valid? it seems strange to me to have 4 bytes for a temperature, i.e. having a potential range of +/- 214 million degrees

@@ -7,9 +7,9 @@ r,,Status16,Aussentemperatur,,,,16,,,temp,,,
# HC Betriebsart2,,,,,,,,,,,,,
*r,,,,,,"B511",,,,,,,
*uw,,,,,,"B510",,,,,,,
uw,,SetMode,Betriebsart,,,,00,,,hcmode,,,,flowtempdesired,,temp1,,,,hwctempdesired,,temp1,,,,hwcflowtempdesired,,temp0,,,,,,IGN:1,,,,disablehc,,BI0,,,,disablehwctapping,,BI1,,,,disablehwcload,,BI2,,,,,,IGN:1,,,,remoteControlHcPump,,BI0,,,,releaseBackup,,BI1,,,,releaseCooling,,BI2,,,,
uw,,SetMode,Betriebsart,,,,00,,,hcmode,,,,flowtempdesired,,temp1,,,,hwctempdesired,,temp1,,,,hwcflowtempdesired,,temp1,,,,,,IGN:1,,,,disablehc,,BI0,,,,disablehwctapping,,BI1,,,,disablehwcload,,BI2,,,,,,IGN:1,,,,remoteControlHcPump,,BI0,,,,releaseBackup,,BI1,,,,releaseCooling,,BI2,,,,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure about the change to temp1? if yes, it would be at least missing in the en file

@@ -29,20 +29,20 @@ calibration1,D1C,,K,
calibrations,SCH,2,K,
calibrationv,EXP,,K,
integral,SIN,,°min,
hcmode,UCH,0=auto;1=off;2=heat;2=water,,Boiler Modus
hcmode,UCH,0=auto;1=off;2=heat;3=water,,Boiler Modus
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure about this change? if yes, it is weirdly missing in the en file though

@john30 john30 marked this pull request as ready for review December 22, 2024 15:37
john30 added a commit that referenced this pull request Dec 22, 2024
@john30
Copy link
Owner

john30 commented Dec 22, 2024

relevant parts of this PR were merged in 452508b even though some questions remain as in new review request

@john30
Copy link
Owner

john30 commented Dec 29, 2024

please check the next generated csvs with ebusd 24.1 (or current source) as described there or by using a local clone of https://github.com/eBUS/ebus.github.io and using the "next" folder in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants