-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added VMS8/D "vmd01", SW0108, HW1703 (AuroStep Plus Drainback solar controller) #199
Draft
pagaille
wants to merge
2
commits into
john30:master
Choose a base branch
from
pagaille:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # type (r[1-9];w;u),circuit,name,[comment],[QQ],ZZ,PBSB,[ID],field1,part (m/s),datatypes/templates,divider/values,unit,comment | ||
| #,VMD01,VMS 8/D,0020071488 243,,,,,,,,,, | ||
| *r,,,,,,"B509","0D",,,,,, | ||
| *w,,,,,,"B509","0E",,,,,, | ||
| *wi,#install,,,,,"B509","0E",,,,,, | ||
| # ##### Generell #####,,,,,,,,,,,,, | ||
| r,,T5,T5 Sensor,,,,"0500",,,tempsensor,,,Solar collector Temperature | ||
| r,,T1,T1 Sensor,,,,"0700",,,tempsensor,,,Temperature in solar back flow (from solar collector) | ||
| r,,T7,T7 Sensor,,,,"0C00",,,tempsensor,,,Average temperature in tank (computed from T6 and mid tank sensor values)) | ||
| r,,PowerOnCounter,PowerOnCounter,,,,"1900",,,UIN,,, Power On Counter (in hours) | ||
| r,,T6,T6 Sensor,,,,"A100",,,tempsensor,,,Average temperature in tank (computed from T6 and mid tank sensor values)) | ||
| # r;wi,,SolPumpRelay,Relais Solarpumpe,,,,"0F00",,,onoff,,,Solar pump relay: 0: OFF; 1: ON | ||
| # r;wi,,SolPumpPower,Leistung Solarpumpe,,,,"9E00",,,power,,,Performance of solar pump: (7 - 100 %) | ||
| r;wi,,FlowRate,Volumenstrom,,,,"9E00",,,SIN,10,l/min,chosen flow rate of the collector pump (to calculate solar gain) | ||
| # r;wi,,BufferPumpPower,Leistung Pufferpumpe,,,,"1100",,,power,,,Performance of buffer pump: (15 - 100%) | ||
| # r,,MonitorMatlabLast5minSolAverage,MonitorMatlab_Last5minSolarAverage,,,,"1700",,,SIN,,, | ||
| # r,,CurrentVPMLoadingMode,Aktuelle Betriebsart,,,,"1900",,,UCH,,,1 = Warmwasser (autonom)2 = Heizung (autonom)3 = +10K (autonom)4 = Schwimmbad5 = Warmwasser6 = Heizung7 = +10K | ||
| # r,,RunTimePump1Minutes,Laufzeit Pumpe 1,,,,"1A00",,,minutes0,,,Laufzeit der Solarpumpe (Minuten Anteil) | ||
| # r,,RunTimePump1Hours,Laufzeit Pumpe 1,,,,"1B00",,,hoursum2,,,Laufzeit der Solarpumpe (Stunden Anteil) | ||
| # r,,ExternalHwcRequest,Externe Warmwasseranforderung,,,,"1C00",,,onoff,,,0: No request; 1: Request | ||
| # r,,ExternalHcRequest,Externe Heizungsanforderung,,,,"1D00",,,onoff,,,0: No request; 1: Request | ||
| # r,,ExternalHwcTempDesired,Externer Warmwassersollwert,,,,"1E00",,,desiredtemp,,,Requested temperature for DHW | ||
| # r,,ExternalHcTempDesired,Externer Heizungssollwert,,,,"1F00",,,desiredtemp,,,Requested temperature for CH | ||
| # r,,CurrentASCStateforExternals,CurrentASCStateforExternals,,,,"2000",,,UCH,,,1:OFF 2: Proofing 3:DHWLoading 4:CHLoading 5:Overtemperature | ||
| # r,,CurrentASCStateforASI,CurrentASCStateforASI,,,,"2100",,,UCH,,,1: Standby 2:Proofing 3:StorageLoading 4:Error_System_blocked | ||
| # r,,DateAndTimeIsSet,DateAndTimeIsSet,,,,"2200",,,onoff,,,0: Date and Time is not set; 1: Date and Time is set | ||
| # r;wi,,Time,Zeit,,,,"1900",,,time,,, | ||
| # r;wi,,Date,Datum,,,,"1900",,,date,,, | ||
| # r,,FlowSensorFrequency,FlowSensorFrequency,,,,"2D00",,,UIN,,, | ||
| # r,,Runtime,Laufzeit Kollektorpumpe,,,,"1900",,,hoursum2,,,accumulated runtime of the collector pump |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # type (r[1-9];w;u),circuit,name,[comment],[QQ],ZZ,PBSB,[ID],field1,part (m/s),datatypes/templates,divider/values,unit,comment | ||
| #,VMD01,VMS 8/D,0020071488 243,,,,,,,,,, | ||
| *r,,,,,,"B509","0D",,,,,, | ||
| *w,,,,,,"B509","0E",,,,,, | ||
| *wi,#install,,,,,"B509","0E",,,,,, | ||
| # ##### Generell #####,,,,,,,,,,,,, | ||
| r,,T5,T5 Sensor,,,,"0500",,,tempsensor,,,Solar collector Temperature | ||
| r,,T1,T1 Sensor,,,,"0700",,,tempsensor,,,Temperature in solar back flow (from solar collector) | ||
| r,,T7,T7 Sensor,,,,"0C00",,,tempsensor,,,Average temperature in tank (computed from T6 and mid tank sensor values)) | ||
| r,,PowerOnCounter,PowerOnCounter,,,,"1900",,,UIN,,, Power On Counter (in hours) | ||
| r,,T6,T6 Sensor,,,,"A100",,,tempsensor,,,Average temperature in tank (computed from T6 and mid tank sensor values)) | ||
| # r;wi,,SolPumpRelay,Relais Solarpumpe,,,,"0F00",,,onoff,,,Solar pump relay: 0: OFF; 1: ON | ||
| # r;wi,,SolPumpPower,Leistung Solarpumpe,,,,"9E00",,,power,,,Performance of solar pump: (7 - 100 %) | ||
| r;wi,,FlowRate,Volumenstrom,,,,"9E00",,,SIN,10,l/min,chosen flow rate of the collector pump (to calculate solar gain) | ||
| # r;wi,,BufferPumpPower,Leistung Pufferpumpe,,,,"1100",,,power,,,Performance of buffer pump: (15 - 100%) | ||
| # r,,MonitorMatlabLast5minSolAverage,MonitorMatlab_Last5minSolarAverage,,,,"1700",,,SIN,,, | ||
| # r,,CurrentVPMLoadingMode,Aktuelle Betriebsart,,,,"1900",,,UCH,,,1 = Warmwasser (autonom)2 = Heizung (autonom)3 = +10K (autonom)4 = Schwimmbad5 = Warmwasser6 = Heizung7 = +10K | ||
| # r,,RunTimePump1Minutes,Laufzeit Pumpe 1,,,,"1A00",,,minutes0,,,Laufzeit der Solarpumpe (Minuten Anteil) | ||
| # r,,RunTimePump1Hours,Laufzeit Pumpe 1,,,,"1B00",,,hoursum2,,,Laufzeit der Solarpumpe (Stunden Anteil) | ||
| # r,,ExternalHwcRequest,Externe Warmwasseranforderung,,,,"1C00",,,onoff,,,0: No request; 1: Request | ||
| # r,,ExternalHcRequest,Externe Heizungsanforderung,,,,"1D00",,,onoff,,,0: No request; 1: Request | ||
| # r,,ExternalHwcTempDesired,Externer Warmwassersollwert,,,,"1E00",,,desiredtemp,,,Requested temperature for DHW | ||
| # r,,ExternalHcTempDesired,Externer Heizungssollwert,,,,"1F00",,,desiredtemp,,,Requested temperature for CH | ||
| # r,,CurrentASCStateforExternals,CurrentASCStateforExternals,,,,"2000",,,UCH,,,1:OFF 2: Proofing 3:DHWLoading 4:CHLoading 5:Overtemperature | ||
| # r,,CurrentASCStateforASI,CurrentASCStateforASI,,,,"2100",,,UCH,,,1: Standby 2:Proofing 3:StorageLoading 4:Error_System_blocked | ||
| # r,,DateAndTimeIsSet,DateAndTimeIsSet,,,,"2200",,,onoff,,,0: Date and Time is not set; 1: Date and Time is set | ||
| # r;wi,,Time,Zeit,,,,"1900",,,time,,, | ||
| # r;wi,,Date,Datum,,,,"1900",,,date,,, | ||
| # r,,FlowSensorFrequency,FlowSensorFrequency,,,,"2D00",,,UIN,,, | ||
| # r,,Runtime,Laufzeit Kollektorpumpe,,,,"1900",,,hoursum2,,,accumulated runtime of the collector pump | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translation is missing on many lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @john30 I'm totally not fluent in German. Beside this, I personally believe that English is the vehicular language when it goes to technical things. I don't really see the added the value of translating to another language since those parameters will be used by a frontend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any other reason that this pull request is pending?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translation is missing / it is a great mixture of english in german and vice versa, not really nice
maybe you want to fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally insist on the missing registers that are still to be discovered instead of arguing about not translated strings in a backend-oriented software. What about the missing Farsi translation btw ? That’s not a good way to encourage people contributing.