-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve code and comments, uniformly upgrade the versions of setup-go
and checkout
in the action
operation.
#384
Conversation
…etup-go` and `checkout` in the `action` operation.
Increadible your PR, thank you for the contribution. I will review it better soon. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
==========================================
- Coverage 79.89% 79.84% -0.04%
==========================================
Files 61 61
Lines 2018 2018
==========================================
- Hits 1612 1611 -1
- Misses 378 379 +1
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix these comments? They are mostly copy & paste.
👌 |
Description
1.Improve code and comments, uniformly upgrade the versions of
setup-go
andcheckout
in theaction
operation.2.Upgrade
pdfcpu
version to v0.6.03.Execute
go mod tidy
to remove irrelevant indirect dependenciesRelated Issue
#386
Checklist
func (<first letter of struct> *struct) method() {}
name style.when,should
naming pattern.make examples
to update all examples inside docs/examples.make dod
with none issues pointed out bygolangci-lint