Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve code and comments, uniformly upgrade the versions of setup-go and checkout in the action operation. #384

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

houseme
Copy link
Contributor

@houseme houseme commented Jan 10, 2024

Description

1.Improve code and comments, uniformly upgrade the versions of setup-go and checkout in the action operation.
2.Upgrade pdfcpu version to v0.6.0
3.Execute go mod tidy to remove irrelevant indirect dependencies

Related Issue

#386

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • Updated docs/doc.go and docs/*
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

@johnfercher
Copy link
Owner

Increadible your PR, thank you for the contribution. I will review it better soon.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (2dd0925) 79.89% compared to head (7bf9c98) 79.84%.

Files Patch % Lines
pkg/metrics/metrics.go 0.00% 4 Missing ⚠️
pkg/components/page/page.go 0.00% 3 Missing ⚠️
internal/providers/gofpdf/text.go 0.00% 1 Missing ⚠️
pkg/merge/merge.go 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   79.89%   79.84%   -0.04%     
==========================================
  Files          61       61              
  Lines        2018     2018              
==========================================
- Hits         1612     1611       -1     
- Misses        378      379       +1     
  Partials       28       28              
Flag Coverage Δ
unittests 79.84% <30.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@johnfercher johnfercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix these comments? They are mostly copy & paste.

internal/cache/mutexcache.go Outdated Show resolved Hide resolved
internal/cache/mutexcache.go Outdated Show resolved Hide resolved
internal/cache/mutexcache.go Outdated Show resolved Hide resolved
internal/cache/mutexcache.go Outdated Show resolved Hide resolved
internal/fixture/fixture.go Outdated Show resolved Hide resolved
pkg/props/cell.go Outdated Show resolved Hide resolved
pkg/props/color.go Outdated Show resolved Hide resolved
pkg/props/color.go Outdated Show resolved Hide resolved
pkg/props/color.go Outdated Show resolved Hide resolved
pkg/props/page.go Outdated Show resolved Hide resolved
@houseme houseme requested a review from johnfercher January 10, 2024 17:13
@houseme
Copy link
Contributor Author

houseme commented Jan 10, 2024

Could you fix these comments? They are mostly copy & paste.

👌

@johnfercher johnfercher merged commit d6015b5 into johnfercher:master Jan 10, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants