Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

low memory mode #427

Merged
merged 8 commits into from
May 18, 2024
Merged

low memory mode #427

merged 8 commits into from
May 18, 2024

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented May 17, 2024

Description

  • 13% improvement

Sequential Mode (Default)
Screenshot from 2024-05-17 19-05-42

Concurrent Mode (7 chunks)
Screenshot from 2024-05-17 19-01-47

Sequential Low Memory Mode (7 chunks)
Screenshot from 2024-05-17 19-07-41

Related Issue

#392

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go
  • Updated README.md
  • Executed make examples to update all examples inside docs/examples.
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.90%. Comparing base (074ffd7) to head (bec6351).

Files Patch % Lines
maroto.go 76.93% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   82.12%   81.90%   -0.21%     
==========================================
  Files          61       61              
  Lines        2063     2099      +36     
==========================================
+ Hits         1694     1719      +25     
- Misses        341      350       +9     
- Partials       28       30       +2     
Flag Coverage Δ
unittests 81.90% <87.24%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 63c15b4 into master May 18, 2024
6 of 7 checks passed
@johnfercher johnfercher deleted the feature/stream-mode branch May 18, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant