Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the color picker in settings.json #531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dembeck
Copy link

@dembeck dembeck commented Aug 17, 2023

Changes

  • Added "format": "color" to each color setting.
    • This makes the color picker available when editing settings.json.
  • Defined property types for peacock.favoriteColors.
    • This was required to add "format": "color" to this setting.

Related Issues

Pictures

image


image

@johnpapa
Copy link
Owner

This pull request primarily focuses on enhancing the package.json file by adding specific formats to various properties and introducing new properties to the items object. The changes are aimed at improving the configuration of the application and making it more user-friendly.

Here are the important changes:

  • package.json: Added "format": "color" to the following properties: peacock.color, peacock.darkForegroundColor, peacock.lightForegroundColor, peacock.remoteColor, peacock.vslsJoinColor, and peacock.vslsShareColor. This change ensures that the input for these properties is validated as a color format. [1] [2] [3] [4]

  • package.json: Enhanced the items object by adding properties with name and value fields, both of type string and value also having a "format": "color". This addition provides a more structured way to specify favorite colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants