Skip to content

Commit

Permalink
Bug #109 Fix tests and Elastica compatibility (#110)
Browse files Browse the repository at this point in the history
* Bug #109 Fix tests and Elastica compatibility

* SF Flex is global
  • Loading branch information
damienalexandre committed Aug 16, 2022
1 parent 42d8632 commit 36081aa
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ jobs:
- name: Install Symfony Flex
run: composer global require --no-progress --no-scripts --no-plugins symfony/flex

- name: Enable Symfony Flex
run: composer global config --no-plugins allow-plugins.symfony/flex true

- name: Install Composer dependencies
run: composer update --prefer-dist --no-interaction --no-ansi ${{ matrix.composer-flags }}

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Run the tests on a custom Elasticsearch port, fix #56
* Improve Exception message when Factory is used badly
* Compatibility with Elastica #109

## [1.5.1] - 2022-01-18

Expand Down
10 changes: 0 additions & 10 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,3 @@ parameters:
message: "#^Parameter \\#1 \\$data of method Elastica\\\\Document\\:\\:setData\\(\\) expects array\\|string, object given\\.$#"
count: 1
path: src/Result.php

-
message: "#^Else branch is unreachable because previous condition is always true\\.$#"
count: 1
path: src/Transport/HttpClientTransport.php

-
message: "#^Strict comparison using \\=\\=\\= between '0' and array will always evaluate to false\\.$#"
count: 1
path: src/Transport/HttpClientTransport.php
2 changes: 1 addition & 1 deletion src/IndexBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function migrate(Index $currentIndex, array $params = []): Index
$newIndex = $this->createIndex($pureIndexName);

$reindex = new Reindex($currentIndex, $newIndex, $params);
$reindex->setWaitForCompletion(Reindex::WAIT_FOR_COMPLETION_FALSE);
$reindex->setWaitForCompletion(false);

$response = $reindex->run();

Expand Down

0 comments on commit 36081aa

Please sign in to comment.