Skip to content

Issue #2705 fix #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Issue #2705 fix #3104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd0a6bf
limitedSwipe default value to true in GetTransitionMixin
May 3, 2024
b490236
fix: Update limitedSwipe default value in GetTransitionMixin
May 6, 2024
4ef0105
refactor: Update limitedSwipe default value in GetTransitionMixin
May 6, 2024
b3cef01
refactor: Update limitedSwipe default value in cupertino transition
May 6, 2024
1f5a882
Merge remote-tracking branch 'upstream/master'
May 20, 2024
d809ae0
limitedSwipe = true to fix issue #2705
May 20, 2024
6f8f578
Merge remote-tracking branch 'upstream/5.0.0-release-candidate-6'
May 27, 2024
5576ebd
Merge branch 'jonataslaw:master' into master
keremkabiloglu Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added lib/.DS_Store
View file
Open in desktop
Binary file not shown.
13 changes: 7 additions & 6 deletions lib/get_navigation/src/routes/default_transitions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ import 'circular_reveal_clipper.dart';

class LeftToRightFadeTransition {
Widget buildTransitions(
BuildContext context,
Curve? curve,
Alignment? alignment,
Animation<double> animation,
Animation<double> secondaryAnimation,
Widget child) {
BuildContext context,
Curve? curve,
Alignment? alignment,
Animation<double> animation,
Animation<double> secondaryAnimation,
Widget child,
) {
return SlideTransition(
position: Tween<Offset>(
begin: const Offset(-1.0, 0.0),
Expand Down
3 changes: 1 addition & 2 deletions lib/get_navigation/src/routes/get_transition_mixin.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ class GetBackGestureDetectorState<T> extends State<GetBackGestureDetector<T>> {
)
},
);

return Stack(
fit: StackFit.passthrough,
children: [
Expand Down Expand Up @@ -361,7 +360,7 @@ Cannot read the previousTitle for a route that has not yet been installed''',
Animation<double> animation,
Animation<double> secondaryAnimation,
Widget child, {
bool limitedSwipe = false,
bool limitedSwipe = true,
double initialOffset = 0,
}) {
// Check if the route has an animation that's currently participating
Expand Down