Skip to content

fix: support maximum queued concurrency - #646

Merged
jonathanong merged 1 commit into
mainfrom
codex/concurrency-queue
Aug 16, 2026
Merged

fix: support maximum queued concurrency#646
jonathanong merged 1 commit into
mainfrom
codex/concurrency-queue

Conversation

@jonathanong

@jonathanong jonathanong commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • accept GitHub Actions concurrency.queue: max at workflow and job scope
  • reject dynamic, non-string, and unsupported queue policies
  • preserve reusable-workflow typecheck coverage when queued concurrency is enabled

Root cause

The concurrency schema recognized only group and cancel-in-progress. A valid workflow using GitHub's FIFO queue: max policy was therefore omitted from the reusable-workflow catalog, which made every downstream typecheck behind that call graph unreachable to tsconfig-gate-coverage.

Validation

  • cargo test -p no-mistakes tsconfig_gate_coverage --lib (473 passed)
  • cargo clippy -p no-mistakes --lib --tests -- -D warnings
  • cargo fmt --all -- --check
  • cargo run -q -p no-mistakes -- check
  • git diff --check

Related issues

  • Closes jonathanong/filaments#9333
  • Refs jonathanong/filaments#9225; the downstream migration remains open until it consumes the released fix.

Follow-ups

None.

Shepherd Journal

  • Codecov report was transient: JavaScript patch coverage was complete while the Rust coverage job was still active, so no code change was warranted.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 16, 2026
@coderabbitai

This comment has been minimized.

@sourcery-ai

This comment has been minimized.

@codecov

This comment has been minimized.

@jonathanong
jonathanong marked this pull request as ready for review August 16, 2026 00:38

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jonathanong, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@jonathanong
jonathanong merged commit 8558ce5 into main Aug 16, 2026
21 of 22 checks passed
@jonathanong
jonathanong deleted the codex/concurrency-queue branch August 16, 2026 00:39
@codspeed-hq

codspeed-hq Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 54 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing codex/concurrency-queue (a32534a) with main (e095d99)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant