feat: add no-mistakes-config rule for path, glob, and limit lints - #761
Merged
Conversation
Opt-in filesystem rule that checks loaded .no-mistakes.yml for missing project/test path refs, empty include/exclude globs, and env-level limit combined with a direct group. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
jonathanong
enabled auto-merge (squash)
August 22, 2026 18:50
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CI rustfmt failed on wrap after adding NO_MISTAKES_CONFIG. Co-authored-by: Cursor <cursoragent@cursor.com>
rust-max-lines-per-file rejected paths.rs at 205 code lines. Co-authored-by: Cursor <cursoragent@cursor.com>
pub(super) in collect.rs could not be re-exported from paths.rs. Co-authored-by: Cursor <cursoragent@cursor.com>
GlobMatcher already accepts &[String]; pass from_ref instead of cloning into a one-element array. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Register the rule in the aggregate filesystem check gate, treat omitted groups as the default Direct set, and require files or a parseable percent before reporting an env-level limit conflict. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Exercise runner path refs, glob triggers, percent limits, and empty globs so rust coverage stays above the 99% gate. `root: .` is a present directory. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
jonathanong
added a commit
that referenced
this pull request
Aug 22, 2026
An environment with all: true applies the limit to the all-tests fallback, so treating omitted groups as an implicit Direct budget is a false positive. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
jonathanong
added a commit
that referenced
this pull request
Aug 22, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep both no-mistakes-config and the newly merged postgres-no-offset dispatch registrations. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
jonathanong
added a commit
that referenced
this pull request
Aug 23, 2026
Keep workflow-topology-policy registered alongside postgres-no-offset. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Keep no-mistakes-config registered alongside postgres-require-query-annotation. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
jonathanong
added a commit
that referenced
this pull request
Aug 23, 2026
Keep workflow-topology-policy registered alongside postgres-require-query-annotation. Co-authored-by: Cursor <cursoragent@cursor.com>
* feat: add workflow-topology-policy rule and step-order helpers Declarative GitHub Actions inventory, required/forbidden jobs and edges, artifact edges, exact fan-in, callers, step order, and unlocked reasons. JS topology index gains directCallerJobIdsForUses and stepOrderIndexes. Co-authored-by: Cursor <cursoragent@cursor.com> * chore: drop leftover local binary version stamps These files were untracked local artifacts and should not ship with the workflow-topology-policy change. Co-authored-by: Cursor <cursoragent@cursor.com> * style: oxfmt workflow-topology-index helper import Pre-push oxfmt check rejected the single-line destructure. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: run workflow-topology-policy from the aggregate check gate Same FILESYSTEM_RULE_IDS hole as no-mistakes-config: the rule would not run when it was the only filesystem rule enabled. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: publish workflow-topology-index-helpers with the package The index entry requires the helper, but the files allowlist omitted it so installed packages failed to load createWorkflowTopologyIndex. Co-authored-by: Cursor <cursoragent@cursor.com> * test: assert published topology-index requires stay in the files list Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Keep no-mistakes-config and workflow-topology-policy registered alongside postgres-no-add-column. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Keep no-mistakes-config and workflow-topology-policy registered alongside postgres-require-named-constraints. Co-authored-by: Cursor <cursoragent@cursor.com>
The #768 filesystem_dispatch conflict resolution dropped two imported constants used by the dispatch macro. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Exercise required/forbidden jobs and edges, fan-in, callers, lock intent, and artifact edges so the new rule modules can meet the 99.5% line gate. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep no-mistakes-config and workflow-topology-policy registered alongside postgres-require-fk-on-delete. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Keep no-mistakes-config, workflow-topology-policy, and postgres-sql-statement-policy registered together after #772. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
jonathanong
added a commit
that referenced
this pull request
Aug 23, 2026
Keep pnpm-overrides-ban registered with no-mistakes-config and workflow-topology-policy after #761. Co-authored-by: Cursor <cursoragent@cursor.com>
jonathanong
added a commit
that referenced
this pull request
Aug 23, 2026
Keep package-json-required-fields registered with no-mistakes-config and workflow-topology-policy after #761. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-mistakes-configfilesystem rule for the loaded.no-mistakes.yml.limitcombined with adirectgroup.Test plan
Made with Cursor
Shepherd Journal