perf(graph): extend canonical edges without repeated NodeId clones - #834
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanong
force-pushed
the
execute-plan/79dd0742-pr-4-reduce-nodeid-clones-in-selector-edge-append
branch
from
September 5, 2026 07:06
103510d to
febafd0
Compare
jonathanong
marked this pull request as ready for review
September 5, 2026 07:27
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanong
force-pushed
the
execute-plan/79dd0742-pr-4-reduce-nodeid-clones-in-selector-edge-append
branch
from
September 5, 2026 07:40
febafd0 to
edfe5d8
Compare
This comment has been minimized.
This comment has been minimized.
jonathanong
force-pushed
the
execute-plan/79dd0742-pr-4-reduce-nodeid-clones-in-selector-edge-append
branch
from
September 5, 2026 07:46
edfe5d8 to
68c58af
Compare
This comment has been minimized.
This comment has been minimized.
jonathanong
force-pushed
the
execute-plan/79dd0742-pr-4-reduce-nodeid-clones-in-selector-edge-append
branch
from
September 5, 2026 07:51
68c58af to
1f94e2c
Compare
This comment has been minimized.
This comment has been minimized.
Use map entry APIs and move accepted edges into adjacency so selector append does not clone NodeId five times per edge.
jonathanong
force-pushed
the
execute-plan/79dd0742-pr-4-reduce-nodeid-clones-in-selector-edge-append
branch
from
September 5, 2026 07:56
1f94e2c to
d6a55b7
Compare
This comment has been minimized.
This comment has been minimized.
jonathanong
deleted the
execute-plan/79dd0742-pr-4-reduce-nodeid-clones-in-selector-edge-append
branch
September 5, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extend_edges_preserving_ordinalsnow uses mapentry/get_mutAPIs and moves acceptedCanonicalEdges into adjacency so selector append does not cloneNodeIdfive times per edge. Ordinals stay base-then-new; duplicates are still skipped.Local Criterion (source of truth)
Machine: macOS aarch64, rustc 1.96.0,
--sample-size 20,NO_MISTAKES_BENCH_SHARD=graph-production. Same machine before/after. CodSpeed is not used as a gate. Peak memory was not printed by this Criterion run.selector_appendnode_id_finalization(control; path unchanged)Shepherd Journal
IC_kwDOSaSRXM8AAAABStKgwA/IC_kwDOSaSRXM8AAAABStKiwAand Sourcery budget reviewPRR_kwDOSaSRXM8AAAABMTHoGgare bot-limit notices, not code findings; minimize only.IC_kwDOSaSRXM8AAAABStOecA/IC_kwDOSaSRXM8AAAABStQZ6A/IC_kwDOSaSRXM8AAAABStRqUQare bot-limit notices; minimize only.IC_kwDOSaSRXM8AAAABStTN5gis a bot-limit notice; minimize only.