feat: add C version of CPI program #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Oct 9, 2024
cpi/c/src/main.c
Outdated
Comment on lines
43
to
45
| uint8_t data[4 + 8]; | ||
| *(uint16_t *)data = 8; | ||
| *(uint64_t *)(data + 4) = SIZE; |
There was a problem hiding this comment.
nit: Can you add the comments from the original here?
Suggested change
| uint8_t data[4 + 8]; | |
| *(uint16_t *)data = 8; | |
| *(uint64_t *)(data + 4) = SIZE; | |
| uint8_t data[4 + 8]; // Enough room for the Allocate instruction | |
| *(uint16_t *)data = 8; // Allocate instruction enum value | |
| *(uint64_t *)(data + 4) = SIZE; // Size to allocate |
There was a problem hiding this comment.
added 7559567
my bad 7559567 |
joncinque
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.