instruction: Fixup instruction data transmute #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The `InstructionData` helper creator doesn't work for all possible types, since the `@sizeOf` macro does not use packed size. #### Summary of changes Use `@bitSizeOf` instead, and add a test.
joncinque
added a commit
that referenced
this pull request
Nov 9, 2024
#### Problem #5 fixed the instruction data helper, but it's not released. #### Summary of changes Bump to 0.14.2 for release.
joncinque
added a commit
that referenced
this pull request
Nov 9, 2024
#### Problem #5 fixed the instruction data helper, but it's not released. #### Summary of changes Bump to 0.14.2 for release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
InstructionDatahelper creator doesn't work for all possible types, since the@sizeOfmacro does not use packed size.Summary of changes
Use
@bitSizeOfinstead, and add a test.