Skip to content

Fix cache path inconsistency when running from non-project directory #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jongalloway merged 2 commits into from
Feb 26, 2026
Merged

Fix cache path inconsistency when running from non-project directory #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c05d9b
Initial plan
Copilot Feb 26, 2026
824a4fa
Fix: centralize cache path using repoRoot and pass to CacheService
Copilot Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/NewsletterGenerator/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,10 @@ public static async Task<int> RunGenerateAsync(GenerateSettings settings)
}
}

var cacheDir = Path.Combine(repoRoot, "src", "NewsletterGenerator", ".cache");

if (clearCache)
{
var cacheDir = Path.Combine(repoRoot, "src", "NewsletterGenerator", ".cache");
if (Directory.Exists(cacheDir))
{
Directory.Delete(cacheDir, recursive: true);
Expand All @@ -256,7 +257,7 @@ public static async Task<int> RunGenerateAsync(GenerateSettings settings)
}
}

var cache = new CacheService(loggerFactory.CreateLogger<CacheService>(), forceRefresh: forceRefresh);
var cache = new CacheService(loggerFactory.CreateLogger<CacheService>(), cacheDir, forceRefresh: forceRefresh);

string? content;
string title;
Expand Down
Loading