Fixed problem with split view not scrolling #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… child element has native scrolling capabilities and therefore should not be added with add_with_viewport() as per this ("http://www.pygtk.org/docs/pygtk/class-gtkscrolledwindow.html#method-gtkscrolledwindow--add-with-viewport") documentation of GtkScrolledWindow.
|
I can confirm that this fixes the problem in Gedit 3.4.1 as well, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #4, the bottom window of the split view does not scroll in response to keyboard commands.
As it turns out this is because the view is added to a GtkScrolledWindow using add_with_viewport(). This is wrong. If the child element has native scrolling (which is the case here), it should be added with add().
This documentation ("http://www.pygtk.org/docs/pygtk/class-gtkscrolledwindow.html#method-gtkscrolledwindow--add-with-viewport") supports my conclusion, as does the fact that it resolves Issue #4... at least in Gedit 3.6.2.