Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak travis build #80

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

maxime-rainville
Copy link
Contributor

Fixing broken build introduce in #78

@jonom
Copy link
Owner

jonom commented May 11, 2020

FYI, I tried with ^1.6 and 1.6.x-dev and both failed.

@jonom
Copy link
Owner

jonom commented May 11, 2020

Maybe it should just be dev-master?

@maxime-rainville maxime-rainville force-pushed the pulls/3/fix-broken-build branch from 9d0aa53 to ba6a724 Compare May 11, 2020 21:13
@maxime-rainville maxime-rainville marked this pull request as ready for review May 11, 2020 21:13
@maxime-rainville
Copy link
Contributor Author

The problem was that there wasn't a minimum stability define in focus-point's composer.json. So it implicitly defaulted to stable. I've tweak it to say that dev dependencies are allowed. This should allow the travis build to install the dev branches.

Note that this change won't make any difference for people installing focus point on their project. Composer only honours the minimum stability of the root composer.json file.

The build is still failing but those failures were pre-existing. I got these errors while I was developing #78 and running the test locally.

@jonom
Copy link
Owner

jonom commented May 15, 2020

Perfect, that did the trick. Thanks for your help. Yes there was an existing build failure, going to revert the cause of that and then we'll be green again.

@jonom jonom merged commit c269189 into jonom:master May 15, 2020
@maxime-rainville maxime-rainville deleted the pulls/3/fix-broken-build branch May 25, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants