Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Adjust the links for more details within the HTTP Header Plugin #44658

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Dec 22, 2024

Summary of Changes

Adjust the links for more details within the HTTP Header Plugin

Testing Instructions

Check the Configuration Options for the Strict-Transport-Security within the plugin before and after the patch

Actual result BEFORE applying this Pull Request

The hsts preload list is linked from the first option which is not quite correct as that site is only relevant when the preload option is set.

image

Expected result AFTER applying this Pull Request

The main header links to the mozilla MDN and the hsts preload page is linked from the preload setting only which makes more sense.

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

…on only and the generad description similiar to the other sites
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Dec 22, 2024
@fgsw
Copy link

fgsw commented Dec 23, 2024

I have tested this item ✅ successfully on f906b5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44658.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on f906b5a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44658.

@alikon
Copy link
Contributor

alikon commented Dec 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44658.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 28, 2024
@pe7er pe7er self-assigned this Jan 9, 2025
@Hackwar Hackwar merged commit f30b2cc into joomla:5.2-dev Jan 9, 2025
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 9, 2025
@pe7er pe7er added this to the Joomla! 5.2.4 milestone Jan 9, 2025
@Hackwar
Copy link
Member

Hackwar commented Jan 9, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants