-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] alter assets TABLE COLUMNS name, title #44664
Conversation
I don’t think code review is sufficient for testing. I think it needs a real test with creating a category for an extension with a long extension name. This test will then show that there will be other errors happening besides the one mentioned in the issue when using such long category titles. |
I have reviewed the code, and it seems fine. However, code review alone isn't enough for testing. We need a real test by creating a category with a long extension name to identify any additional issues beyond the one mentioned This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664. |
yes if someone can share such extension .... |
I have tested this item 🔴 unsuccessfully on 30f5be7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664. |
I have tested this item 🔴 unsuccessfully on 30f5be7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664. |
how do you apply the patch ? |
administrator/components/com_admin/sql/updates/postgresql/5.3.0-2024-12-23.sql
Outdated
Show resolved
Hide resolved
…0-2024-12-23.sql Co-authored-by: Richard Fath <[email protected]>
administrator/components/com_admin/sql/updates/postgresql/5.3.0-2024-12-23.sql
Outdated
Show resolved
Hide resolved
…0-2024-12-23.sql Co-authored-by: Richard Fath <[email protected]>
i'll not invest much more time on this |
Pull Request for Issue #42671 .
Summary of Changes
ALTER "name" and "title" columns to varchar(255) for #__assets table
ALTER "name" and "title" columns to varchar(255) for #__assets table
ALTER "extension" to varchar(100) for #__categories table
ALTER "extension" to varchar(255) for #__workflows and #__workflow_associations tables
Testing Instructions
code review
and or install this demo extensions
https://test5.richard-fath.de/com_testextensionwithlongname_100.zip
thanks to @richard67