Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] alter assets TABLE COLUMNS name, title #44664

Closed
wants to merge 7 commits into from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 23, 2024

Pull Request for Issue #42671 .

Summary of Changes

ALTER "name" and "title" columns to varchar(255) for #__assets table
ALTER "name" and "title" columns to varchar(255) for #__assets table
ALTER "extension" to varchar(100) for #__categories table
ALTER "extension" to varchar(255) for #__workflows and #__workflow_associations tables

Testing Instructions

code review
and or install this demo extensions
https://test5.richard-fath.de/com_testextensionwithlongname_100.zip
thanks to @richard67

@richard67
Copy link
Member

richard67 commented Dec 23, 2024

I don’t think code review is sufficient for testing. I think it needs a real test with creating a category for an extension with a long extension name. This test will then show that there will be other errors happening besides the one mentioned in the issue when using such long category titles.

@nileshmittha
Copy link

I have reviewed the code, and it seems fine. However, code review alone isn't enough for testing. We need a real test by creating a category with a long extension name to identify any additional issues beyond the one mentioned


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664.

@alikon alikon marked this pull request as ready for review February 22, 2025 06:53
@alikon
Copy link
Contributor Author

alikon commented Feb 22, 2025

yes if someone can share such extension ....

@nileshmittha
Copy link

I have tested this item 🔴 unsuccessfully on 30f5be7

Though I mentioned as "code review alone isn't enough for testing", I checked by applying this patch and unfortunately it is not working.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664.

@Tejashrimajage
Copy link

I have tested this item 🔴 unsuccessfully on 30f5be7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44664.

@alikon
Copy link
Contributor Author

alikon commented Feb 22, 2025

how do you apply the patch ?

@alikon alikon marked this pull request as draft February 22, 2025 08:33
@alikon alikon marked this pull request as ready for review March 9, 2025 12:37
@alikon alikon marked this pull request as draft March 9, 2025 12:37
@alikon
Copy link
Contributor Author

alikon commented Mar 24, 2025

i'll not invest much more time on this

@alikon alikon closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants