[5.2 ]#44636 add scroll-margin-top if sticky top is used #44679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue 44636 .
Summary of Changes
This PR has a css change. It will apply a scroll-margin-top when sticky header is used.
The value of
scroll-margin-top
is set by custom property--cassiopeia-scroll-margin-top
with a fallback to 10rem. Because custom property is used it can be set using javascript too. This might be useful when the height of the header is unknown. Out of scope for this PR.When header in your custom Cassiopea template is larger you can override
--cassiopeia-scroll-margin-top
to another value in user.css or use javascript to set it in the style element.Testing Instructions
#anchor
. Add it to Menu Blognpm ci
to compile new css. (or something similar... css needs to be recompiled)Actual result BEFORE applying this Pull Request
My set anchor position next to Your site is hidden behind the sticky header.
Expected result AFTER applying this Pull Request
My set anchor position next to Your site is visible below the sticky header.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed