Skip to content

[6.0] Implement progress bar for Media Manager image edits #45155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

[6.0] Implement progress bar for Media Manager image edits #45155

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
87c271d
Implement createProgressBar and removeProgressBar methods
mahmoudmagdy1-1 Mar 18, 2025
bfc0b94
Add ESLint disable comments
mahmoudmagdy1-1 Mar 18, 2025
6074e98
removed TODO's and comments
mahmoudmagdy1-1 Mar 18, 2025
e85d8bb
Removed changing on left (redundant)
mahmoudmagdy1-1 Mar 18, 2025
5332bc2
Revert Unix permissions
mahmoudmagdy1-1 Mar 19, 2025
fd4ec12
Refactor progress bar implementation & Remove ESLint comments
mahmoudmagdy1-1 Mar 19, 2025
6998357
Revert UNIX Permission for the template file
mahmoudmagdy1-1 Mar 19, 2025
5ada9fb
Merge branch '5.3-dev' into 5.2-dev
mahmoudmagdy1-1 Mar 25, 2025
821fe39
Merge branch '5.4-dev' into 5.2-dev
bembelimen Mar 25, 2025
b60d231
Merge branch '5.4-dev' into 5.2-dev
richard67 Mar 27, 2025
24c0333
Fix indentation
mahmoudmagdy1-1 Apr 13, 2025
8340aad
Merge branch '5.4-dev' into 5.2-dev
richard67 Apr 13, 2025
cf0de50
Merge branch '6.0-dev' into 5.2-dev
richard67 Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions administrator/components/com_media/tmpl/file/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,13 @@
$this->useCoreUI = true;
?>
<?php if ($tmpl === 'component') : ?>
<div class="subhead noshadow mb-3">
<?php echo $this->getDocument()->getToolbar('toolbar')->render(); ?>
</div>
<div class="subhead noshadow mb-3">
<?php echo $this->getDocument()->getToolbar('toolbar')->render(); ?>
</div>
<?php endif; ?>
<div id="progress" class="progress visually-hidden">
<div id="progress-bar" class="progress-bar bg-success" role="progressbar" aria-valuenow="0" aria-valuemin="0" aria-valuemax="100"></div>
</div>
<form action="#" method="post" name="adminForm" id="media-form" class="form-validate main-card media-form mt-3">
<?php $fieldSets = $form->getFieldsets(); ?>
<?php if ($fieldSets) : ?>
Expand All @@ -72,4 +75,4 @@
<?php endif; ?>
<input type="hidden" name="mediatypes" value="<?php echo $this->escape($mediaTypes); ?>">
</form>
<script type="module" src="<?php echo $script . '?' . $this->getDocument()->getMediaVersion(); ?>"></script>
<script type="module" src="<?php echo $script . '?' . $this->getDocument()->getMediaVersion(); ?>"></script>
27 changes: 18 additions & 9 deletions build/media_source/com_media/js/edit-images.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,17 +155,26 @@ class Edit {
// eslint-disable-next-line class-methods-use-this
Redo() { }

// @TODO Create the progress bar
// eslint-disable-next-line class-methods-use-this
createProgressBar() { }
createProgressBar() {
this.progress = document.getElementById('progress');
this.progressBar = document.querySelector('.progress-bar');
this.progress.classList.remove('visually-hidden');
}

// @TODO Update the progress bar
// eslint-disable-next-line class-methods-use-this
updateProgressBar(/* position */) { }
updateProgressBar(position) {
if (this.progressBar) {
this.progressBar.style.width = `${position}%`;
this.progressBar.setAttribute('aria-valuenow', position);
}
}

// @TODO Remove the progress bar
// eslint-disable-next-line class-methods-use-this
removeProgressBar() { }
removeProgressBar() {
if (this.progress && this.progressBar) {
this.progress.classList.add('visually-hidden');
this.progressBar.style.width = '0';
this.progressBar.setAttribute('aria-valuenow', '0');
}
}

/**
* Uploads
Expand Down