WIP: Add support for radio programs #30
Conversation
|
I have additional code for audio support. For example settings page for selecting what type of content is listed in search and other lists. Maybe that can be integrated after this. It could be that the reason why I didn't finish it was the subtitle bug because I couldn't play any audio streams. |
|
I just made another test and I cannot get any audio streams to play, the URL obtained from API returns error 404. |
Did you have the API part also already? Would you like to add your changes here and I could finish the feature or do you prefer to continue this feature after the API part is done & working? Or something else? :) |
I think I faced same issues the other day I tried to make this, will continue maybe this week unless we decide something else ☝️ |
|
I'll check my sources tomorrow and rebase on top of this. Most of the new code is for the settings part but also some API changes to read the settings. |
|
Radio streams are working now, checked from YLE API support and the issue was the protocol, HLS streams for audio did not work but with PMD streams started to work. :) Cool that this can be added also. Would you like to add the other code here or continue from this with your additional stuff? :) @mlehtima |
…ulldown menu to change between radio&tv modes, need to reflect the change into categories etc.
|
I thought I tried all of the protocols already but seems I didn't, good that radio now works. I will check the code and test this and if it works well then we can merge and I will then finish my changes for limiting searching to videos or audio. |
|
Sounds good, I'll pick something else next in the meantime then :) 👍 |
|
My idea is that I would like this to be quite similar with the official app, so you could select from first page's pull down menu the content type (radio/tv) and then you would have basically similar experience all the time except the content is either radio or tv, not both mixed. Opinions? :) |
|
That in one way to do it, maybe easier than my way of having a settings page to select which content is shown (audio, video, audioclip, videoclip, all). |
| @@ -235,16 +308,18 @@ var api = (function(appId, appKey) { | |||
| getProgramsByCategoryId: getProgramsByCategoryId, | |||
| getProgramsBySeriesId: getProgramsBySeriesId, | |||
| search: search, | |||
| getCurrentRadioBroadcasts: getCurrentRadioBroadcasts, | |||
There was a problem hiding this comment.
This is missing the getNowPlayingRadioPrograms function which is used in FirstPage.qml. Also the function is missing from below in function list. In addition to this there now seems to be two functions which are probably supposed to do the same thing getNowPlayingRadioPrograms and getCurrentRadioBroadcasts.
There was a problem hiding this comment.
Sorry, renamed the getNowPlayingRadioPrograms into getCurrentRadioBroadcasts and forgot to rename it into FirstPage.qml.
The two methods are using different endpoints, the other (not used atm) returns the currently playing songs/programs in the given radiochannel and which I thought was needed for listening those songs. Not sure if we want to show information about next/current/previous songs somewhere in the app?
|
Found a small issue, sometimes first page shows many duplicate programs because service list has all of the local versions of the same channel and all list the same program, maybe some check of duplicates might be useful? Also this radio program support currently only works in first page and not in other parts, maybe those can be done later. I had some code already for that. |
No description provided.