WIP: Feature/joonne/data storage #37
Conversation
joonne
commented
Jul 30, 2019
•
joonne
commented
- Sketching the data storage with JSON serialization
- Implemented first version of Resume Functionality #11 already as a proof on concept
|
wdyt? I'm just testing around, wanted to get lighter data storage implementation and I thought JSON would serve us well enough as the data model? |
… can be detected easily if the first onChange is from that.
| @@ -33,6 +33,10 @@ Page { | |||
| if (visible) updateCover(qsTr("Now playing"), program.title, program.itemTitle) | |||
| } | |||
|
|
|||
| Component.onDestruction: { | |||
| appWindow.insertStartedProgram({ id: program.id, progress: mediaPlayer.position }) | |||
There was a problem hiding this comment.
check if this is called upon closing the app by a swipe and make sure this is called also when pause button is pressed in case the handle isn't called upon closing the app forcefully
qml/pages/PlayerPage.qml
Outdated
| @@ -41,6 +45,7 @@ Page { | |||
| subtitlesText.getSubtitles(subtitlesUrl) | |||
| } | |||
| mediaPlayer.source = response.url | |||
| if (appWindow.state.startedPrograms[program.id]) mediaPlayer.seek(appWindow.state.startedPrograms[program.id]) | |||
There was a problem hiding this comment.
Maybe this could be more readable if this had curly brackets and function call inside those or at least an empty line after this because otherwise it's possible to read that the if affects the next line. Also the line is quite long now.
| #include <QTextStream> | ||
| #include <QStandardPaths> | ||
| #include <QDir> | ||
| #include <QDebug> |
There was a problem hiding this comment.
Maybe make the include list alphabetically ordered.
| Q_INVOKABLE QJsonObject getState(); | ||
|
|
||
| signals: | ||
| public slots: |
There was a problem hiding this comment.
Do we want to have the empty signals and public slots defined here?
| QFile file(this->getPath()); | ||
|
|
||
| if (!file.open(QIODevice::ReadWrite)) | ||
| { |
There was a problem hiding this comment.
Move curly bracket to same line with if which is the style used in other files. Same for other if statements in the new code.
|
I also wonder about the efficiency of the code because both setState and getState make copies of the state. Need to check the code more carefully and also investigate is compiler will optimize those situations to something more efficient. |
… continue on a program that is in progress.
