Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'undefined' sticky pageHeader in SaveAs mode #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix 'undefined' sticky pageHeader in SaveAs mode #7

wants to merge 2 commits into from

Conversation

thangngoc89
Copy link
Collaborator

Currently linkText is being handled in multiple places and leads to undefined linkText in SaveAs mode.
I decided to fix linkText right after headerProps parsing would be the best course of action.

Places that currently handles linkText:

@thangngoc89
Fix 'undefined' sticky pageHeader in SaveAs mode
b1df863
@thangngoc89
Move linkText normalization to handleFetchDone
cf3eef2 
- Current pageKey is only available in handleFetchDone
  We have no access to it in `fetcher`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thangngoc89