Align SwiftUI ViewModel behavior to KMP ViewModel #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping a Kotlin viewmodel inside an ObservableObject On iOS, the kotlin viewModel will have the same behavior as the swiftui viewModel The kotlin viewmodel method cancelViewModelScope will be call from Swift when the ObservableObject is deinit.
|
Looking at following approach as I think it makes things a bit cleaner #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from issue : #231
On Shared project :
ViewModel.cancelViewModelScopewhich cancel the viewModelScopeIt will be called from SwiftUI when the deinit of the viewmodel is done
On iOS :
Now, the KMP viewModel lifecycle is mapped with the SwiftUI viewModel lifecycle
We're using a
@StateObjectand not a@Stateto hold the viewmodel as it's the best way to handleObservableObjectas intented by SwiftUI.the issue #229 is now useless with this upgrade.