optype.numpy.CanArrayND: remove scalar type parameter default
#354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
This does indeed seem to fix the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the PEP 696 default of the first
optype.numpy.CanArrayNDgeneric type parameter (covariant and bound tonp.generic). This is technically a breaking change, but given its absence from the docs, I don't expect it to be likely that this will cuase issues for optype users.This works around a path-dependent bug in Pyright (<=1.1.403) that has recently been causing a lot of issues in scipy-stubs.
See scipy/scipy-stubs#745, scipy/scipy-stubs#742, and scipy/scipy-stubs#741 for more info about this pyright bug.