-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize Breakpoints in Multiple Buffers #2007
base: master
Are you sure you want to change the base?
Conversation
* Traverse open python mode buffers and retrieve breakpoints that were set by elpy * Specify breakpoints using full file path and line number
Any news on this PR? I would really like to use it in my emacs without having to patch the files every time. |
Hey, maintainership for elpy has sadly slowed down with all the maintainers not having enough time. Sadly I don't know much about this area of the code and it has been a while in general since i've done work with elpy. Might not be able to get to this soon |
Hey @pweibert, have you been using this PR for a while? any issues arise? LGTM but want to verify since I'm not using elpy and I am slowly starting to have time to help out again, and would like to get all PR's merged :) Thx! |
Hello @gopar, happy to hear that you have time to move some things forward :). Yes, I've tested the code a while and it was stable for me. Let me describe the basic functionality. So PR basically takes care that all breakpoints are collected from open buffers and are passed to pdb with file-name and line-number per breakpoint. It is much more convenient to debug the whole project and not just the main file. |
docs/ide.rst
Outdated
Run pdb on the current buffer. If no breakpoints has been set in any | ||
open buffer with elpy mode using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run pdb on the current buffer. If no breakpoints has been set in any | |
open buffer with elpy mode using | |
Run pdb on the current buffer. If no breakpoints have been set in any | |
open buffer with elpy mode using |
Nice!, left 3 comments. After those are resolve and CI passes, then everything should be good to merge! |
Changes incorporated! |
Ah looks like some tests broke. I'll merge once passing. appreciate the work! \o/ |
Ok I'll have a look on the next time I have a free slot.
Am Mo., 24. Juli 2023 um 19:16 Uhr schrieb Gopar ***@***.***>:
… Ah looks like some tests broke. I'll merge once passing. appreciate the
work! \o/
—
Reply to this email directly, view it on GitHub
<#2007 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANUM6QC4OCSRSUOVPUWLKVLXR2UWZANCNFSM6AAAAAATOHZRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
With this feature debugger will not just interrupt execution at breakpoints in the buffer it was called on (main buffer) but also on breakpoints that were set in other buffers that whose code has been executed by main buffer.
Thus when we set a breakpoint in
main.py
buffer and one insubmodule/mod.py
buffer starting the debugger in main will interrupt on execution of main but recognize the breakpoint insubmodule/mod.py
and interrupt execution.