Skip to content

Commit

Permalink
Leave package access scope to the package configuration
Browse files Browse the repository at this point in the history
We just got badly burnt by the current behaviour of this plugin.

Scoped packages, e.g. `@org/package` are restricted by default, e.g. an `npm publish` publishes them privately whilst the default behaviour of npm for a unscoped package is to publish it publicly; e.g. `package` will be release `public` with a simple `npm publish`.
This plugin diverts from the default npm behaviour in that it releases all packages, independent of their configuration or the sane npm default, publicly.

references mikeal#8 

cc @joshua-leyshon-canva
  • Loading branch information
joscha committed Jan 17, 2020
1 parent 3b41cc4 commit 92e913c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion merge-release-run.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const run = async () => {
console.log('current:', current, '/', 'version:', version)
let newVersion = execSync(`npm version --git-tag-version=false ${version}`).toString()
console.log('new version:', newVersion)
exec(`npm publish --access=public`)
exec(`npm publish`)
exec(`git checkout package.json`) // cleanup
exec(`git tag ${newVersion}`)
exec(`git push merge-release --tags`)
Expand Down

0 comments on commit 92e913c

Please sign in to comment.