Improved json serialization / deserialization#2774
Draft
mattvague wants to merge 17 commits intojosdejong:developfrom
Draft
Improved json serialization / deserialization#2774mattvague wants to merge 17 commits intojosdejong:developfrom
mattvague wants to merge 17 commits intojosdejong:developfrom
Conversation
SQUISH object node
Owner
|
Thanks Matt for picking this up 👍 The reason that there is no recursive implementation of Docs: https://mathjs.org/docs/core/serialization.html So right now, I think if you use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue albeit in a slightly different way than was described. Instead of implementing
toObjectandfromObjectI opted to instead:fromObjectfunction (which I'm callingfromJSONsince I think that makes its purpose more obvious)toJSONmethods on each node type to deeply serialize to JSON.fromJSONmethods on each node type to deeply deserialize from JSONNote I'd be happy to add a generic
toJSONfunction as well but I honestly am not sure I see the value when you can always just callnode.toJSON(), but maybe I'm missing somethingNote @josdejong I wasn't sure if there was a reason these methods didn't work "deeply" before, but it seems to me like they would be most useful this way no?