This repository has been archived by the owner on Aug 12, 2023. It is now read-only.
feat(diagnostics): add cmake_lint to go alongside cmake_format #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchallain
force-pushed
the
feature/cmake_lint
branch
from
af8a891
to
7498653
Compare
| "$FILENAME", | ||
| }, | ||
| format = "line", | ||
| to_stdin = false, |
There was a problem hiding this comment.
So as currently written, the linter will read the file on disk, which means that diagnostics won't update properly until the file is actually written. It does seem that cmake-lint has stdin support, but this PR seems to imply that it doesn't currently work.
Using stdin would be ideal, but other options that we have are writing the buffer's contents to a temp file or only generating diagnostics on save.
There was a problem hiding this comment.
I see, thanks for the feedback. Personal preference would be to switch to DIAGNOSTICS_ON_SAVE. Judging by the age of that PR in cmake_format, stdin may not be fixed soon.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
cmake_lintdiagnostics support from thecmakelangPython package, which provides the already supportedcmake_formatbuiltin.cmake_lintdoes not provide anend_col, so this currently goes to EOL, making underlines a little messy.