Fixed PIDtest bug

Nearly half of the results of any IV to PID search were lost due to the whacky behaviour of the % operator for negative inputs (-1 % n returns -1, not n-1).
josemam · Oct 10, 2016 · 2d18559 · 2d18559
1 parent 69f5dd2
commit 2d18559
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/func.cpp b/src/func.cpp
@@ -35,7 +35,7 @@ IVtester GetIVtester(bool exact) {
 }
 
 bool PIDtest(uint32_t pid, int nature, int ability) {
-  return (nature == -1 || (int) pid%25 == nature) && (ability == 2 || (int) pid%2 == ability);
+  return (nature == -1 || (int) (pid%25) == nature) && (ability == 2 || (int) (pid%2) == ability);
 }
 
 bool HPpretest(uint16_t iv, int hpt, int hpp) {