[WIP] feat: Implement get*NoiseValue functions #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet fully implemented to the point of being able to merge in. will need to update documentation and update tests
lukehesluke
commented
Jun 7, 2024
| for (let x = 0; x < length; x++) { | ||
| let value = 0.0; | ||
| for (let octave = 0; octave < octaves; octave++) { | ||
| const freq = frequency * Math.pow(2, octaves); |
There was a problem hiding this comment.
Minor note. I think this was a typo and should be octave. It's changed to that in the getLineNoiseValue function
…getSphereSurfaceNoiseValue
lukehesluke
force-pushed
the
feature/noise-value-at-point
branch
from
72b00df to
6c6dcf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress: This is not yet fully implemented to the point of being able to merge in. It needs updated documentation and tests before it can be merged in.