-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new client creation function to allow custom endpoint #10
base: master
Are you sure you want to change the base?
Conversation
This project isn't particularly maintained. I see no problem with this though. :) |
You can transfer the project to me! On Thu, Feb 26, 2015 at 8:58 PM, Timon Vonk [email protected]
|
I was just about to ping you on that! |
I JUST PONGED! On Thu, Feb 26, 2015 at 8:58 PM, Timon Vonk [email protected]
|
HOLY SHIT PREEMPTIVE PONG, YOU PSYCHIC? check your mail |
I'll review this shortly, thanks for the PR! |
What a reaction \o/. (a PR will arrive soon on a client lib in Go too, WIP) |
It's all transfered to @joshk now. He did like 99% more on this than me anyway :-) |
@timonv I ALWAYS DO! :P |
@stumpyfr thanks for the offer, I may just take you up on that. What do you mean by client lib? |
example: currently trying and after I will change the Ctor to allow custom endpoint too |
Ahhh, yes, would be cool to get this into this project! On Thu, Feb 26, 2015 at 9:33 PM, Niels Freier [email protected]
|
A project who can do both (server/client) will be great yes :). |
Here the client with the custom endpoint connection: toorop/go-pusher#1 |
Just wanted to say "hi". I hope you don't mind me hijacking the thread... Thoughts on client v serverThe client (WebSocket endpoint) and server (HTTP endpoint) separation of libraries is an interesting one. One that we've been debating for years. The separation really suits more traditional client/server technology stacks; many of which still exist and developers will continue to build them where it suits. But I also think the separation is quite neat because they do interact with different APIs. I can definitely see the value in having a library that uses both the libraries. A true pub/sub client. But I'd put my +1 towards keeping the two types of library separate. We're still discussing things and it could be that we either offer an additional "authoritative" endpoint that offers full publish functionality (rather than just client events) as well as subscribe functionality. Or we may add an authentication mechanism that gives the WebSocket connection that permission. Library namingWe've just gone through the long process of trying to establish naming conventions for the library. If you care about such things we've decided to go with the following:
The constituents of this name are:
Two examples are:
Library Guidelines/ChecklistWe haven't started this yet. But we do plan to create a set of guidelines for the sorts of things that we'd like to see in libraries. We'll obviously adhere to these ourselves, but it's up to you if you want to do the same. Language conventions winI think it's important to highlight that we want to make sure that each library fits with the conventions of a language rather than trying to shoe-horn some sort of common API into each language. I know this is common-sense, but it's worth confirming. Helping community librariesI think we can do better at this. I'd be interested in hearing if you agree? What would help you make the most of the Go libraries? Happy to continue the discussion here, elsewhere or via email. [email protected] |
Useful if you need to use custom pusher server (internal usage for example)