Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for authenticating users #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agerlic
Copy link

@agerlic agerlic commented Jan 5, 2014

Proposition to add user authentication based on http://pusher.com/docs/auth_signatures for issue #2

Maybe AuthenticateUser method could be added to Channel instead of Client like the pusher ruby gem (https://github.com/pusher/pusher-gem/blob/master/lib/pusher/channel.rb#L139).

@jnunemaker
Copy link
Contributor

I would rename AuthenticateUser to Authenticate and add it to channel. Since it requires channel name as the first arg, it makes more sense on channel to me. I also would like to see this library line up closely with the pusher ruby gem as I have found it to be pleasant to work with in the past.

@jnunemaker
Copy link
Contributor

We will probably have to pass an instance of the client to the channel then, so we have the key/secret and a way to make other client requests, but that seems fine.

@agerlic
Copy link
Author

agerlic commented Jan 5, 2014

I've renamed and added the Authenticate method to Channel.

I've created a new example file channelAuthenticate, which loads pusher package locally instead of git repo, I guess it could help to fix examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants