Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed foo file #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

removed foo file #193

wants to merge 1 commit into from

Conversation

joshmarinacci
Copy link
Owner

@joshmarinacci joshmarinacci commented Nov 9, 2023 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Description

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 9, 2023 •
edited
Loading

❌ This pull request has been removed from the merge queue because it does not declare required statuses in either .trunk/trunk.yaml or your repo's branch protection rules for master. See more details here.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@joshmarinacci
Copy link
Owner Author

/trunk merge

@joshmarinacci
Copy link
Owner Author

/trunk cancel

@joshmarinacci
Copy link
Owner Author

/trunk merge

joshmarinacci2
joshmarinacci2 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@joshmarinacci2 joshmarinacci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We didn't need that file anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmarinacci2 joshmarinacci2 joshmarinacci2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmarinacci @joshmarinacci2