Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rsp.launch.py #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

neochaos42
Copy link

Fixes rsp.launch.py to load robot description as a string

Fixes rsp.py to load robot description as a string
@neochaos42
Copy link
Author

Without this patch it tries to load the xacro as a yaml file which is undesired

@joshnewans
Copy link
Owner

Thanks, I had been meaning to chase this one down! (I had seen the warnings but not looked into it as it seemed to work).

I'll merge it in once I have a chance to flag it in a video so that things are kept in sync :)

@neochaos42
Copy link
Author

May need to change this line too
https://github.com/neochaos42/articubot_one/blob/76dd9c412cf8f92c5f65b4a996269bf4ada1b441/launch/launch_robot.launch.py#LL49C4-L49C105

@neochaos42
Copy link
Author

For me rsp would not launch at all without this patch

@joshnewans
Copy link
Owner

Really? With everything else the same?
I have had no issues (bar the occasional warning), tested on Foxy and Humble (only sim on Humble so far, hopefully running on the robot this week). I'd really like to understand the exact context in which it fails (certain xacro files maybe?).

I don't really want to merge it blindly without flagging it in a video since they are meant to be kept "in sync" but I will definitely make it a priority (and hopefully others with the same issue who are capable will find your fixes here).

@neochaos42
Copy link
Author

@neochaos42
Copy link
Author

Based on foxy with only slight variations due to my robot design

@0jeetparmar0 0jeetparmar0 mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants