Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Improve keyboard navigation in our forms #316

Open
3 tasks
AWolf81 opened this issue Nov 1, 2018 · 6 comments
Open
3 tasks

Improve keyboard navigation in our forms #316

AWolf81 opened this issue Nov 1, 2018 · 6 comments
Labels
good first issue Good for newcomers

Comments

@AWolf81
Copy link
Collaborator

AWolf81 commented Nov 1, 2018

During my work on AppSettingsModal I've noticed that keyboard navigation through the form is not supported yet.
I think it's needed to have a more native ux.

Describe the solution you'd like

  • Tab key should move the focus to the next form field forward and shift+tab backwards. Starting at the first element.
  • Project icon selection should support left, right, up & down navigation & enter key to move the focus out of the selection area.
  • Escape key should dismiss modals

Optional: Add navigation with left,right,up & down to move the focus.

Forms to check

  • CreateNewProjectWizard
  • ProjectConfigurationModal
  • AppSettingsModal

Note:
There is more to improve e.g. keyboard navigation in sidebar & project page. But I think we should tackle this in a separate issue.

@AWolf81 AWolf81 added the good first issue Good for newcomers label Nov 1, 2018
@tomas914
Copy link

tomas914 commented Nov 4, 2018

Hi, I would like to work on this issue (my first issue)... Is there anything more I should know while getting familiar with Guppy?

@AWolf81
Copy link
Collaborator Author

AWolf81 commented Nov 4, 2018

Hi @tomas914, great to hear that you'd like to support Guppy. The issue is all yours.

For getting started with Guppy code base I think Contribution.md should help.

If you're having something to show or you need support during your work you can create a "work in progress" pull request.

If you're having any questions you can ask on Gitter.

@ayjaweems
Copy link

Hi @AWolf81 , I would like to take a shot at this for my first issue! Is this still up for grabs?

@AWolf81
Copy link
Collaborator Author

AWolf81 commented Oct 1, 2019

@aeweems sure, this is still open.

Please give it a shot. I haven't worked on Guppy for some time but if you have something to review I'll have a look.

If you need help please let me know.

@grimxreaper
Copy link

Hi @AWolf81 @joshwcomeau is this issue up for grabs? I'd love to do this for my first issue! I see the last comment was over a year ago and it is still open.

@AWolf81
Copy link
Collaborator Author

AWolf81 commented May 14, 2021

Hi @grimxreaper, sure, but the repo is pretty inactive for two years.
To continue working, I'd pick up the PR mentioned here. Probably just the mentioned keyboard navigation in the icons is open but I haven't checked.
At the moment, I'm working more on my blog. So not sure how good I can support here but if you need help, just open a draft PR and mention me there.
I'm also not sure if other people are investing time. Josh Comeau is probably busy with his courses etc.

Before investing time in this app, I'd check if there is still an audience for it. I'm boostrapping my Svelte apps (I'm currently learning it) with npm init svelte@next and start with npm run dev.
The only helper apps / addons I'm currently using are inside VS code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants