This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Esc dismisses Modal component #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWolf81
reviewed
Oct 10, 2019
| @@ -73,6 +77,12 @@ class Modal extends PureComponent<Props, State> { | |||
| } | |||
| } | |||
|
|
|||
| handleKeyboardEvent = (event: any) => { | |||
| if (event.keyCode === 27) { | |||
There was a problem hiding this comment.
Nit. Escape handling is working but I would use if (event.key === 'Escape') { }.
We could also leave it with the keyCode as it's only one key here but with the string, it's more readable.
|
Hi! Does this completely fix issue #316 ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#316
Summary:
Pressing the Esc key dismisses the Modal component for:
To do: