-
Notifications
You must be signed in to change notification settings - Fork 154
Conversation
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 20.73% 24.86% +4.12%
==========================================
Files 248 152 -96
Lines 3945 3628 -317
Branches 391 389 -2
==========================================
+ Hits 818 902 +84
+ Misses 2846 2452 -394
+ Partials 281 274 -7
|
@idoberko2 would be great if you could review the setup and first tests? If there is nothing against using Enzyme we can merge this to have the setup ready and we can continue to add more tests afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a question about a file I wasn't sure about.
Also since you were adding /* eslint-disable flowtype/require-valid-file-annotation */
to the tests missing it, do you mind doing it to WhimsicalInstaller.helpers.test.js
and Initialization.helpers.test.js
? Just found out they are also not disabled and we can just do it in this branch.
@@ -0,0 +1,19 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with what we're having in the repo for VSCode settings, was this supposed to be committed? If so what does it do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to add the launch settings so it's possible to use the integrated debugger during testing - so you can add breakpoints etc. Just open the debugger pane (striked-through bug icon, see screenshot below) select the configuration & click play. (No config in the screenshot)
OK, I'll check the other test files and also disable flowjs there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've fixed all linting errors. Also added two unrelated flow linting errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's cool 👍
@AWolf81, how do you want to proceed with this one? |
@idoberko2 if the setup is OK in this PR, we can merge it to master. Can we merge this? Then you can branch from master and we can track progress on issue #309. Just add the components you'd like to work-on as a comment and I'll add mine (if I'm adding some tests - no progress on my side at the moment). |
@AWolf81, the setup looks good and I can confirm it runs successfully on my environment both via the CLI and the VSCode integration. |
Related Issue:
#309
Summary:
Tests