This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Semantic colors #377
Merged
Semantic colors #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 57.91% 57.94% +0.02%
==========================================
Files 158 158
Lines 3329 3331 +2
Branches 462 462
==========================================
+ Hits 1928 1930 +2
Misses 1195 1195
Partials 206 206
|
superhawk610
reviewed
Apr 5, 2019
There was a problem hiding this comment.
Good stuff. It will be a somewhat colossal effort to go through and decide on a case-by-case basis where to convert existing RAW_COLORS usages, so I'm OK with committing this PR as-is so we can start using the new naming scheme now and adding the color normalization as a goal for the next release milestone.
It could also be nice to add a brief sentence or two in the Storybook explaining the purpose of semantic colors and when it's OK to deviate from them (only when an existing COLORS value absolutely won't work).
superhawk610
approved these changes
Apr 5, 2019
|
I'll extract the lingering to-dos into an issue :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on branch from @mathieudutour (see PR #326). Taking over to bring it up to date with master and get it ready.
To Do:
From #326:Look at the shades of blue and purple used, decide onprimaryandsecondarycolorsGo through the remaining RAW_COLORS and decide whether we want to add a new semantic color, make an exception, or better, change it to use an existing semantic color.Anything else?Moved lingering to-dos to #378