-
Notifications
You must be signed in to change notification settings - Fork 154
Conversation
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 57.91% 57.94% +0.02%
==========================================
Files 158 158
Lines 3329 3331 +2
Branches 462 462
==========================================
+ Hits 1928 1930 +2
Misses 1195 1195
Partials 206 206
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. It will be a somewhat colossal effort to go through and decide on a case-by-case basis where to convert existing RAW_COLORS
usages, so I'm OK with committing this PR as-is so we can start using the new naming scheme now and adding the color normalization as a goal for the next release milestone.
It could also be nice to add a brief sentence or two in the Storybook explaining the purpose of semantic colors and when it's OK to deviate from them (only when an existing COLORS
value absolutely won't work).
I'll extract the lingering to-dos into an issue :) |
Based on branch from @mathieudutour (see PR #326). Taking over to bring it up to date with master and get it ready.
To Do:
From #326:Look at the shades of blue and purple used, decide onprimary
andsecondary
colorsGo through the remaining RAW_COLORS and decide whether we want to add a new semantic color, make an exception, or better, change it to use an existing semantic color.Anything else?Moved lingering to-dos to #378