Skip to content

Commit

Permalink
Update buildtools doctor to check for Java 11 and not 8 (mit-cml#3277)
Browse files Browse the repository at this point in the history
  • Loading branch information
josmas authored Dec 6, 2024
1 parent 381891d commit ec1e463
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions buildtools
Original file line number Diff line number Diff line change
Expand Up @@ -137,18 +137,18 @@ doctor() {
((pass++))
echo [PASS] Java is installed.
# Check Java version
if java -version 2>&1 | grep -q "version \"1.8" &> /dev/null; then
if java -version 2>&1 | grep -q "version \"11." &> /dev/null; then
((pass++))
echo [PASS] Required version of Java is installed.
else
((fail++))
echo [FAIL] Required version of Java is not installed or not found on PATH.
echo _______Please install Java 8 and try again.
echo _______Please install Java 11 and try again.
fi
else
((fail++))
echo [FAIL] Java is not installed or not found on PATH.
echo _______Please install Java 8 and try again.
echo _______Please install Java 11 and try again.
fi
# Check if git is installed
if command -v git &> /dev/null; then
Expand Down
6 changes: 3 additions & 3 deletions buildtools.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -151,19 +151,19 @@ if /i "%ERRORLEVEL%" equ "0" (
set /a pass=pass+1
echo [PASS] Java is installed.
:: Check Java version
java -version 2>&1 | find "version ""1.8" > nul 2>&1
java -version 2>&1 | find "version ""11." > nul 2>&1
if /i "%ERRORLEVEL%" equ "0" (
set /a pass=pass+1
echo [PASS] Required version of Java is installed.
) else (
set /a fail=fail+1
echo [FAIL] Required version of Java is not installed or not found on PATH.
echo _______Please install Java 8 and try again.
echo _______Please install Java 11 and try again.
)
) else (
set /a fail=fail+1
echo [FAIL] Java is not installed or not found on PATH.
echo _______Please install Java 8 and try again.
echo _______Please install Java 11 and try again.
)
:: Check if git is installed
where git > nul 2>&1
Expand Down

0 comments on commit ec1e463

Please sign in to comment.