Skip to content

github: Set working directory as safe for git in container - #397

Merged
jp7677 merged 2 commits into
masterfrom
github-git-describe
Sep 19, 2026
Merged

jp7677 merged 2 commits into
masterfrom
github-git-describe

Conversation

@jp7677

@jp7677 jp7677 commented Sep 19, 2026 •

Copy link
Copy Markdown
Owner

Also add an extra step that prints that info (and a bit more). Additionally, that step fails when git denies.

Follow up from #389 (comment) and thus doitsujin/dxvk#5905

@jp7677
jp7677 force-pushed the github-git-describe branch from 60283e3 to e153002 Compare September 19, 2026 08:38
@jp7677 jp7677 changed the title github: Print build-in version and digest github: Set working directory as safe for git in container Sep 19, 2026
@jp7677
jp7677 marked this pull request as ready for review September 19, 2026 08:52
@jp7677
jp7677 requested a review from Saancreed September 19, 2026 08:52
Comment thread .github/workflows/build-llvm.yml Outdated
test -e ./Include || mv ./include ./Include
test -e ./Lib || mv ./lib ./Lib

- name: Print build-in version

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phrasing is a little awkward, How about

Suggested change
- name: Print build-in version
- name: Print build version

or

Suggested change
- name: Print build-in version
- name: Print current version

? Same below.

@jp7677
jp7677 force-pushed the github-git-describe branch from e153002 to 34cd397 Compare September 19, 2026 15:01
@jp7677
jp7677 merged commit 34cd397 into master Sep 19, 2026
4 checks passed
@jp7677
jp7677 deleted the github-git-describe branch October 9, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants