Repository navigation
Add arm64x/ec builds - #398
Conversation
b7eba68 to
dc45381
Compare
Saancreed
left a comment
There was a problem hiding this comment.
Thanks for this, Looks reasonable at a glance, but I have a few questions and/or suggestions.
a81fa8a to
072e3d2
Compare
|
I just added it everywhere i could now, please let me know if there's something here that you dont like/that i should revert again.
One note here is that I'm not testing with an NVIDIA GPU and I dont have a good enough overview of nvapi to test everything |
672b72e to
379417a
Compare
|
Test build with artifacts https://github.com/justradical/dxvk-nvapi/actions/runs/36246467413 |
done! |
There was a problem hiding this comment.
Kind of annoying that we need to fetch the toolchain directly from github, but seems that this is unfortunately the way to go. See some very minor nits/suggestions, otherwise looks good and fine to get this in.
For the long term we could tweak the readme to mention arm64x there as well, but that is for another day. Same for exploring if we can go all the way meson (instead of msbuild directly) for msvc builds.
jp7677
left a comment
There was a problem hiding this comment.
Looks good. Thanks! Do you mind squashing some commits before we merge this?
yeah sure i can move some stuff around here |
745ce3c to
cf244fc
Compare
|
I think this should be pretty good, i created a backup branch just in case |
Adds a cross file, changes how 64 bit is detected by meson and adds arm64ec builds to some of the CI jobs.
The
build-test-package-linux.ymlcan be modified to work with this, but it needs the toolchain from either the AUR or somewhere else so i dropped it.build-llvm.ymldoes not work. xwin does not have arm64ec support so it fails to link:lld-link: could not open 'softintrin.lib'I want to try to get dxvk-nvapi into Proton arm64ec, to do that i need to get it into dxvk-nvapi here. That's the justification behind this change.
I built and tested this locally with Proton Experimental on a Retroid Pocket 6. It looks to be working as expected