Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled DNSSec #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enabled DNSSec #10

wants to merge 2 commits into from

Conversation

bassrock
Copy link

@bassrock bassrock commented Jan 7, 2019

Switching to DNSSec dnsmasq package to support DNSSEC

Copy link

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While DNSSEC is a nice feature, it's unclear if it should be offered by default, especially with dnssec-check-unsigned as that negatively impacts performance for anyone using the image that does not see value / interest in enabling DNSSEC.

Would it be better to switch the package, and provide the config snippet in the README instead so that users can configure DNSSEC if they want to enable it?

Comment on lines +7 to +11
# DNSSEC setup
dnssec
trust-anchor=.,19036,8,2,49AAC11D7B6F6446702E54A1607371607A1A41855200FD2CE1CDDE32F24E8FB5
trust-anchor=.,20326,8,2,E06D44B80B8F1D39A95C0B0D7C65D08458E880409BBC683457104237C7F8EC8D
dnssec-check-unsigned

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should provide context about such configuration values, they should not be trusted otherwise.

The trust-anchors seem legitimate(Gentoo wiki offers the exact same snippet), but rather than adding them inlined here, you should be doing it like this:

conf-file=/usr/share/dnsmasq/trust-anchors.conf
dnssec

dnssec-check-unsigned also looks useful.

Now some replies are not DNSSEC signed but may still be may be legitimate, because the domain is unsigned, or may be forgeries. This setting will have dnsmasq do some various checks to see if it’s still looks valid. Now this will take a few more dns lookups, but it’s good for security. - Source

As a default, dnsmasq does not check that unsigned DNS replies are legitimate: they are assumed to be valid and passed on (without the “authentic data” bit set, of course). This does not protect against an attacker forging unsigned replies for signed DNS zones, but it is fast. If this flag is set, dnsmasq will check the zones of unsigned replies, to ensure that unsigned replies are allowed in those zones. The cost of this is more upstream queries and slower performance. - Source

@jpillora
Copy link
Owner

See upgrade discussion here #24 Once upgraded, I'd consider releasing DNSSEC as a branch, with a corresponding tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants