Fix ListBox not scrolling to the active item in some circumstances (#…

…3900)
jpmorganchase · Jul 26, 2024 · 31c3702 · 31c3702
1 parent ffc0dd4
commit 31c3702
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/.changeset/pretty-feet-dance.md b/.changeset/pretty-feet-dance.md
@@ -0,0 +1,5 @@
+---
+"@salt-ds/core": patch
+---
+
+Fixed ListBox not scrolling to the active item in some circumstances
diff --git a/packages/core/src/list-control/ListControlState.ts b/packages/core/src/list-control/ListControlState.ts
@@ -322,19 +322,10 @@ export function useListControl<Item>(props: ListControlProps<Item>) {
         return;
       }
 
-      const { scrollTop } = listRef.current;
-      const { offsetTop, offsetHeight } = activeElement;
-
-      const isVisible =
-        offsetTop >= scrollTop &&
-        offsetTop + offsetHeight <= scrollTop + listRef.current.offsetHeight;
-
-      if (!isVisible) {
-        activeElement.scrollIntoView({
-          block: "end",
-          inline: "nearest",
-        });
-      }
+      activeElement.scrollIntoView({
+        block: "nearest",
+        inline: "nearest",
+      });
     }
   }, [activeState]);