Update the CI to block merged when linting has errors

jpmorganchase · Jul 11, 2024 · 9542e00 · 9542e00
1 parent 7ea886e
commit 9542e00
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 15 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -20,8 +20,6 @@ jobs:
       - name: Install dependencies
         run: yarn
       - name: Lint
-        # Continue on error so, we can see lint issues but not fail the build, we should fix them incrementally
-        continue-on-error: true
         run: yarn biome ci --reporter=github
       - name: Prettier
         run: yarn run prettier:ci

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -31,7 +31,5 @@
   "scripts": {
     "bundle:css": "yarn node ./scripts/build.mjs"
   },
-  "files": [
-    "css"
-  ]
+  "files": ["css"]
 }
diff --git a/packages/core/stories/menu/menu.stories.tsx b/packages/core/stories/menu/menu.stories.tsx
@@ -289,7 +289,7 @@ export const IconWithGroups: StoryFn<typeof Menu> = (args) => {
 
 export const ContextMenu: StoryFn = () => {
   const [virtualElement, setVirtualElement] = useState<VirtualElement | null>(
-    null
+    null,
   );
   const [open, setOpen] = useState(false);
   return (

diff --git a/packages/lab/package.json b/packages/lab/package.json
@@ -44,7 +44,5 @@
   "scripts": {
     "bundle:css": "yarn node ./scripts/build.mjs"
   },
-  "files": [
-    "css"
-  ]
+  "files": ["css"]
 }
diff --git a/packages/lab/stories/kitchen-sink/kitchen-sink.stories.tsx b/packages/lab/stories/kitchen-sink/kitchen-sink.stories.tsx
@@ -230,12 +230,24 @@ export const Example1 = () => {
         <NotificationIcon />
         <NotificationSolidIcon />
         <Link href="#">Link</Link>
-        <Link href="#" color="secondary">Link</Link>
-        <Link href="#" color="info">Link</Link>
-        <Link href="#" color="success">Link</Link>
-        <Link href="#" color="warning">Link</Link>
-        <Link href="#" color="error">Link</Link>
-        <Link href="#" target="_blank">Link</Link>
+        <Link href="#" color="secondary">
+          Link
+        </Link>
+        <Link href="#" color="info">
+          Link
+        </Link>
+        <Link href="#" color="success">
+          Link
+        </Link>
+        <Link href="#" color="warning">
+          Link
+        </Link>
+        <Link href="#" color="error">
+          Link
+        </Link>
+        <Link href="#" target="_blank">
+          Link
+        </Link>
         <Link href="#" target="_blank" color="secondary">
           Link
         </Link>