Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input docs to site #2297

Merged
merged 42 commits into from
Aug 31, 2023
Merged

Input docs to site #2297

merged 42 commits into from
Aug 31, 2023

Conversation

libertymayc
Copy link
Contributor

@libertymayc libertymayc commented Aug 24, 2023 •
edited by feliciackh
Loading

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 61522ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 9:28am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023 •
edited
Loading

Storybook Preview Link https://f503d0e5.saltdesignsystem-storybook.pages.dev

@libertymayc libertymayc marked this pull request as ready for review August 29, 2023 12:39
mikearildbrown
mikearildbrown reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@mikearildbrown mikearildbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistency changes. we may need to revisit some of these style points after the retro but for now can follow these rules

site/docs/components/input/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/input/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/input/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/input/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/input/accessibility.mdx Outdated Show resolved Hide resolved
site/docs/components/input/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/input/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/input/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/input/examples.mdx Outdated Show resolved Hide resolved
site/docs/components/input/examples.mdx Outdated Show resolved Hide resolved
@james-nash james-nash mentioned this pull request Aug 31, 2023
Open
@origami-z origami-z merged commit dc08432 into main Aug 31, 2023
16 checks passed
@origami-z origami-z deleted the add-input-docs branch August 31, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-nash james-nash james-nash left review comments

@mikearildbrown mikearildbrown mikearildbrown left review comments

@alycrys alycrys alycrys approved these changes

@origami-z origami-z origami-z approved these changes

@sion-docs sion-docs Awaiting requested review from sion-docs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input Documentation
5 participants
@libertymayc @alycrys @origami-z @james-nash @mikearildbrown