Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Status to Text Component #3375

Merged
merged 9 commits into from
May 15, 2024
Merged

Added Status to Text Component #3375

merged 9 commits into from
May 15, 2024

Conversation

Vineet119
Copy link
Contributor

@Vineet119 Vineet119 commented May 8, 2024 •
edited by joshwooding
Loading

Blocked by #2619

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e7a9ef2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@salt-ds/theme Minor
@salt-ds/core Minor
@salt-ds/lab Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 8, 2024

@Vineet119 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented May 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 4:01pm

joshwooding
joshwooding previously requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and prettier needs to be run

@joshwooding joshwooding self-assigned this May 9, 2024
@joshwooding joshwooding self-requested a review May 9, 2024 12:31
@joshwooding joshwooding mentioned this pull request May 9, 2024
Closed
@joshwooding joshwooding force-pushed the status-text-indicator branch 2 times, most recently from 8846dfc to 54e5c93 Compare May 13, 2024 13:59
@joshwooding joshwooding merged commit 25e38e4 into jpmorganchase:main May 15, 2024
15 checks passed
libertymayc pushed a commit that referenced this pull request May 17, 2024
@Vineet119 @libertymayc
Added Status to Text Component (#3375)
fe5c364
@origami-z origami-z mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@JoanaMMoreira JoanaMMoreira JoanaMMoreira approved these changes

Assignees

@joshwooding joshwooding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vineet119 @joshwooding @JoanaMMoreira