Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear all example to ComboBox docs #3378

Merged

Conversation

ThusharaJ07
Copy link
Contributor

@ThusharaJ07 ThusharaJ07 commented May 8, 2024

Implements #3307

Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 1e4c93e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 8, 2024

@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 10:41am

Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i use keyboard to toggle "Select All" option (https://62565e7f.saltdesignsystem-storybook.pages.dev/?path=/story/core-dropdown--select-all), focus is changed to the 2nd item. Is it the intent?

@ThusharaJ07
Copy link
Contributor Author

When i use keyboard to toggle "Select All" option (https://62565e7f.saltdesignsystem-storybook.pages.dev/?path=/story/core-dropdown--select-all), focus is changed to the 2nd item. Is it the intent?

Hey @origami-z , this is an existing issue in dropdown which Shey said will have a word with the team separately. not related to this example.

@origami-z
Copy link
Contributor

Hey @origami-z , this is an existing issue in dropdown which Shey said will have a word with the team separately. not related to this example.

I can only see the issue in dropdown but not combobox, is it to do with key ?

@ThusharaJ07 ThusharaJ07 changed the title added examples for select all in dropdown added examples for select all in combobox May 29, 2024
@ThusharaJ07 ThusharaJ07 changed the title added examples for select all in combobox combobox - select all example May 29, 2024
@joshwooding joshwooding changed the title combobox - select all example Add clear example to ComboBox Jun 5, 2024
@ThusharaJ07 ThusharaJ07 changed the title Add clear example to ComboBox Add Clear All example to ComboBox Jun 5, 2024
@joshwooding joshwooding marked this pull request as ready for review June 5, 2024 10:38
@joshwooding joshwooding changed the title Add Clear All example to ComboBox Add clear all example to ComboBox docs Jun 5, 2024
@joshwooding joshwooding merged commit ed61a2c into jpmorganchase:main Jun 5, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants