-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested stepped tracker #3803
base: main
Are you sure you want to change the base?
Nested stepped tracker #3803
Conversation
🦋 Changeset detectedLatest commit: 1cc1e86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7f41429
to
1cc1fe2
Compare
1cc1fe2
to
83bbf78
Compare
83bbf78
to
93e6458
Compare
93e6458
to
423672f
Compare
423672f
to
9bb92ed
Compare
9bb92ed
to
4d30b89
Compare
4d30b89
to
f266bf4
Compare
wrapping nested steps
b59b906
to
1cc1e86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If our stage holder is happen with this, we should merge this in and ask them to use it in lab.
level
vs depth
is the only doubt for me
/** | ||
* The nesting depth of the TrackerStep | ||
*/ | ||
depth?: Depth; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this is compared with NavigationItem
's level
.
Worth to point out this will take no effect when horizontal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
level
makes sense (and I'm always in favour of consistency)
.saltTrackerStepWrapper-nested-group[aria-hidden="true"] { | ||
grid-template-rows: 0fr; | ||
opacity: 0; | ||
visibility: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether hidden
on HTML will solve this?
Closes #1869
Adds support for nesting steps in a vertical SteppedTracker.
Nesting is achieved via the
depth
prop on theTrackerStep
component. When a step has nested children, the step icon will show an "in progress" icon when some of the children are completed, and a "completed" icon when all children are completed.