Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New button sentiment and appearance #4067

Merged
merged 18 commits into from
Sep 12, 2024
Merged

New button sentiment and appearance #4067

merged 18 commits into from
Sep 12, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Sep 9, 2024 •
edited
Loading

Replaces #3924, #3648

Implements #3325, #3325

Other related - #3971

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: db32160

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/theme Minor
@salt-ds/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 11:06am

@origami-z origami-z mentioned this pull request Sep 9, 2024
Closed
@origami-z origami-z marked this pull request as ready for review September 10, 2024 08:58
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 10, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 10, 2024
@origami-z
Copy link
Contributor Author

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@pseys
Copy link
Contributor

pseys commented Sep 11, 2024

The solid disabled states for caution negative and positive aren't displaying correctly in Salt Next.

@origami-z
Copy link
Contributor Author

The solid disabled states for caution negative and positive aren't displaying correctly in Salt Next.

fixed in a later commit

@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 12, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 12, 2024
@origami-z origami-z merged commit 1098fc1 into main Sep 12, 2024
16 checks passed
@origami-z origami-z deleted the buttons-sentiment-appearance branch September 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate left review comments

@bhoppers2008 bhoppers2008 bhoppers2008 left review comments

@joshwooding joshwooding joshwooding approved these changes

@pseys pseys pseys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@origami-z @pseys @mark-tate @joshwooding @bhoppers2008